Minor doc suggestion #153
Minor doc suggestion #153
Conversation
|
Thanks for the additions. Check why the tests fail as of commit fcfe180 - something is funky from then on. I would like to keep the subheader Use as it is what I implemented everywhere. Consistency matters I think. What I can see is expand the the intro section to include more details of the online setup, in contrast to the setup section of the |
I'm actually not sure what is going wrong here. I don't really understand how the authentification is working in the test. In any case, I also don't see the link with my modifications... Sorry... |
|
My local version runs all checks fine, not sure why the remote version doesn't work. I'll merge and check out changes locally as well. |
|
Passes when pulled. I've been developing for a while alone now so I think this always happens as I use encrypted credentials (environmental variables) on my part for authentication. Since this comes from "outside" as a pull request the tests don't have access to those (otherwise a malicious pull request could exfiltrate these). |
I noticed that CDS is now calling the "Personal Access token" a "API token". It's been a bit confusing, but probably best stick to their name convension, right?
Here are some minor edits (feel free to reject, not offended).
Also, in terms of structure, I could see the heading "Use: ECMWF Data Store services" becoming "Setup" including the content for retrieving the token within this section and start a new level 2 section for Data Requests
"File and system based keychains" sounds more like for the advanced_vignette as well as the issue with date which is now present in both.